regexp help!

Posted: Sat Jan 07, 2012 3:44 pm

I have a text like the following:

16 mb (- 10)

The text could also be:

extra cheese on hamburger (+ 2.50)

i need to strip the text in 3 vars:

var1 (var2 vart3)

Text is alway's formated as above:
-Before the ( is text.
-directly after the ( , is a + or minus sign.
-Between the ( ) , and exclude the plus or minus sign is also a part of the text.

Failed attempts here:

http://jsfiddle.net/whitehat/vrcXY/

Posted: Sun Jan 08, 2012 1:11 am

Code:




    var value = "128 Mb (+ 100)"; // this is an example only





    var temp = value.split("(");


    var memory = temp[0].replace(/\s+$/,""); // trim off space


    var plusminus = temp[1].charAt(0);


    var amount = temp[1].substring(1).replace(/^\s+/,"").replace(")","");





document.write(memory+ "<br />");


document.write(plusminus+ "<br />");


document.write(amount+ "<br />");

You are just using the wrong "keys" for "temp" in two spots.

Posted: Sun Jan 08, 2012 2:34 am

Yes i know palbin (was testing).
i fixed the problem without regexp.

Posted: Wed Feb 08, 2012 4:36 pm

I know I'm a month late to this party... but just a tip I learned about JavaScript... there is no need to call "var" for each, they can be separated with a comma and closed with a semicolon.

I.e.

Code:

var value = "128 Mb (+ 100)", // this is an example only


     temp = value.split("("),


     memory = temp[0].replace(/\s+$/,""), // trim off space


     plusminus = temp[1].charAt(0),


     amount = temp[1].substring(1).replace(/^\s+/,"").replace(")","");

I know it's trivial but it helps keep the code looking cleaner. (Think I got the tip from the online YUI compressor or something like that)

Site Admin/Owner Joined: Aug 27, 2002 Posts: 17088

Good tip! I had forgotten about that one. The more I/you/we use apps like jQuery the more we lose track of all manner of the "roots" from whence we came Laughing

. I guess that's the price we pay for progress, right?

Posted: Fri Feb 10, 2012 2:39 pm

Since we are on the topic of tips, here's another...

When writing in jquery... instead of calling to the dom for each selector... cache the selector at the beginning of the function then use the new variable throughout instead. Again, another "trivial" thing but makes for cleaner, better performing code.

I.e.

Bad: (yes I know this is chainable... not the issue)

Code:

$('#Selector').addClass('fun');


$('#Selector').animate('do stuff');


$('#Selector').fadeOut('slow');

Good:

Code:

Var selector = $('#Selector');


selector.addClass('fun');


selector.animate('do stuff');


selector.fadeOut('slow');