Problem with ABBlockedIPDeleteSave.php

registered · New Member Joined: Sep 13, 2004 Posts: 16

the error I get is:

Fatal error: Maximum execution time of 30 seconds exceeded in /home/mangaman/public_html/admin/modules/sentinel/ABBlockedIPDeleteSave.php on line 40

It seems to still delete the IP because when I went to delete the address from the nsnst_blocked_ips table using phpmyadmin it wasn't there. So I went back to the Display Blocked IP's page and sure enough it was gone, I tryed deleting some more and I still get that error but they are still deleted. Just wanted to let you know.

registered · Posted: Thu Nov 04, 2004 9:30 pm

Here's what's happening, it timing out searching your htaccess file for the ip being deleted.

Code:

        $testip = "deny from $xIPs\n";


        $ipfile = file($abconfig['htaccess_path']);


        $i = 0;


        while ($i <= count($ipfile)) {


          if ($testip == $ipfile[$i]) { $ipfile[$i] = ""; }


          $doip = $doip.$ipfile[$i];


          $i++;


        }


        fwrite($doit, $doip);

If we change this to:

Code:

        $testip = "deny from $xIPs\n";


        $ipfile = file($abconfig['htaccess_path']);


        $ipfile = implode("", $ipfile);


        $ipfile = str_replace($testip, "", $ipfile);


        $doit = fopen($abconfig['htaccess_path'], "w");


        fwrite($doit, $ipfile);

It will no longer time out as it takes the array of $ipfile and converts it into a string of $ipfile and then just does a string replacement Smile

---EDIT----
I'll update the downloads tonite for this as well. I'll also check the other files that interact with the htaccess file and make sure they use the same system instead of search line by line in htaccess Smile