Author |
Message |
jestrella
Moderator

Joined: Dec 01, 2005
Posts: 593
Location: Santiago, Dominican Republic
|
Posted:
Tue Jan 20, 2009 7:15 pm |
|
I've been doing some work on class that I've named nukeICONS... the name says it all, it's a icon theme manager for *nuke. The code might be a little raw at this stage but I want some brave people to give a try and help debug and improve the code. I can send copies to the interested ones. And remember is still on early stage of development.
The icon theme i chose as base to start from was of course Tango Icon Theme, it is released under the Creative Commons Attribution Share-Alike license and will try to adapt as possible to the icon naming specifications from the Tango Project and FreeDestop.org.
Spanish speakers can read the entry at my new blog: http://exuberanza.wordpress.com/2009/01/20/tango-icon-theme-para-ravennukephp-nuke/
I wanna read some suggestions.... |
_________________ "For those whom have not reach the sky... Every mountain seems high"
Best Regards
Jonathan Estrella
http://about.me/jestrella04 |
|
|
 |
kguske
Site Admin

Joined: Jun 04, 2004
Posts: 6437
|
Posted:
Tue Jan 20, 2009 10:18 pm |
|
Hi jestrella,
Can you give a little more info on what the icon theme manager will do? Manage news topic icons and / or admin icons? Or functions with Nuke? Or all of the above...? |
_________________ I search, therefore I exist...
Only registered users can see links on this board! Get registered or login! |
|
|
 |
Palbin
Site Admin

Joined: Mar 30, 2006
Posts: 2583
Location: Pittsburgh, Pennsylvania
|
Posted:
Tue Jan 20, 2009 10:19 pm |
|
I don't understand exactly what it is either.  |
_________________ "Debugging is twice as hard as writing the code in the first place. Therefore, if you write the code as cleverly as possible, you are, by definition, not smart enough to debug it." — Brian W. Kernighan. |
|
|
 |
jestrella

|
Posted:
Tue Jan 20, 2009 10:46 pm |
|
Excuse me if I was not so clear in my original post. It's well known by all of us that all *nuke applications (lets say blocks/addons/modules/etc) use their own graphics all over the way. As you browse from one module to another all graphics might drastically change giving the impression of a non integrated design. This is the situation I am planning to avoid creating this class. instead of all modules linking to their owin images there will be a central function you can call to generate determined icon.
So... instead of adding this to our apps
Code:<img src="path/to/image/here.png" width="32" height="32" alt ="" />
|
We'll call the nukeicons function that will take charge of managing and displaying icons (same icons for all modules/blocks/addons). Function will be called like this:
Code:nukeicons('icon_name_here', 'dimensions_here');
|
This might save us some space on the package here as all images/icons will be located on a specific directory and we could easily dropped all module specific images.
Of course this will require to adapt all present nuke applications from directly showing images to call the function. There's also an admin interface allowing to select default iconset (Currently working with Tango only).
Explained clear enough this time??? |
|
|
|
 |
kguske

|
Posted:
Tue Jan 20, 2009 11:14 pm |
|
Yes, thanks. One possible issue is that themes often override graphics, and the function-specific graphics won't apply (easily) to things like admin icons and news topic icons. |
|
|
|
 |
jestrella

|
Posted:
Wed Jan 21, 2009 10:20 am |
|
Currently, available icon sizes are 16x16, 22x22, 32x32 and 48x48. The class is not so resource intensive but it may need some tweaks.
Here's a screenshot of a script i made to test the class:
 |
|
|
|
 |
jestrella

|
Posted:
Wed Jan 21, 2009 10:32 am |
|
kguske wrote: | Yes, thanks. One possible issue is that themes often override graphics, and the function-specific graphics won't apply (easily) to things like admin icons and news topic icons. |
That's one one of the situation I am planning to avoid using this function. I want to see graphic integration all over the system. |
|
|
|
 |
horrorcode
Involved


Joined: Jan 17, 2009
Posts: 272
Location: Missouri
|
Posted:
Wed Jan 21, 2009 12:27 pm |
|
I love that idea but I think for certain theme specific images you might want to leave it out considering others mods such as AutoTheme, but then again it would be up to the person using it whether they wanted to change those lines in the theme or not. But I'd also love to see more work on AutoTheme, on that note, new post. Either way I'll be looking forward to testing it out |
|
|
|
 |
jestrella

|
Posted:
Mon Jan 26, 2009 10:49 am |
|
|
|
 |
Raven
Site Admin/Owner

Joined: Aug 27, 2002
Posts: 17088
|
Posted:
Mon Jan 26, 2009 3:41 pm |
|
horrorcode raises a very important issue. JEstrella, maybe your function could allow for another parameter like nukeicons('icon_name_here', 'dimensions_here', 'allow_theme_override'); or something along that line. |
|
|
|
 |
Guardian2003
Site Admin

Joined: Aug 28, 2003
Posts: 6799
Location: Ha Noi, Viet Nam
|
Posted:
Mon Jan 26, 2009 5:35 pm |
|
Tried the link but got a page of garbage instead of a 7z package - could be my browser I suppose.
Interesting concept and I'd like to look at it further. One of the first things questions I have though as I cannot see the code is how are you handling ALT tags. |
|
|
|
 |
Susann
Moderator

Joined: Dec 19, 2004
Posts: 3191
Location: Germany:Moderator German NukeSentinel Support
|
Posted:
Mon Jan 26, 2009 5:41 pm |
|
Got the same. So its not your browser. |
|
|
|
 |
Raven

|
Posted:
Mon Jan 26, 2009 5:43 pm |
|
Guardian, use right click -> Save link as ... |
|
|
|
 |
nuken
RavenNuke(tm) Development Team

Joined: Mar 11, 2007
Posts: 2024
Location: North Carolina
|
Posted:
Mon Jan 26, 2009 5:43 pm |
|
in Firefox, right click the link and hit save link as. IE should be similar. |
|
|
|
 |
Raven

|
Posted:
Mon Jan 26, 2009 5:44 pm |
|
I beat! |
|
|
|
 |
nuken

|
Posted:
Mon Jan 26, 2009 5:46 pm |
|
Good advice Raven. I second that. |
|
|
|
 |
Guardian2003

|
Posted:
Mon Jan 26, 2009 5:46 pm |
|
That worked, thanks Raven  |
|
|
|
 |
jestrella

|
Posted:
Mon Jan 26, 2009 11:35 pm |
|
Raven wrote: | horrorcode raises a very important issue. JEstrella, maybe your function could allow for another parameter like nukeicons('icon_name_here', 'dimensions_here', 'allow_theme_override'); or something along that line. |
Uhmm, I am planning to include some other parameters like alt, title, border...
What do you mean with allow_theme_override??? |
|
|
|
 |
Raven

|
Posted:
Tue Jan 27, 2009 4:03 am |
|
Reference horrorcode's post. What if you don't want to use the icons? You would need a way of overriding your system. |
|
|
|
 |
jestrella

|
Posted:
Tue Jan 27, 2009 7:58 am |
|
In fact, it is meant to be used for displaying icons only and will require explicit call of the nukeicon() function. Is up to theme/app developers to use it or not... |
|
|
|
 |
spasticdonkey
RavenNuke(tm) Development Team

Joined: Dec 02, 2006
Posts: 1693
Location: Texas, USA
|
Posted:
Tue Jan 27, 2009 9:35 am |
|
Something like Ikonize would be cool for a re-worked Downloads module
http://ikonize.com/
(automatically adds icons depending on what type of file the link points to) |
|
|
|
 |
testy1
Involved


Joined: Apr 06, 2008
Posts: 484
|
Posted:
Tue Jan 27, 2009 4:54 pm |
|
spasticdonkey wrote: | Something like Ikonize would be cool for a re-worked Downloads module
http://ikonize.com/
(automatically adds icons depending on what type of file the link points to) |
you can do this via css
Code:
a[href$='.pdf'] { padding:0 20px 0 0; background:transparent url(/graphics/icons/pdf.gif) no-repeat center right; }
|
|
|
|
|
 |
Raven

|
Posted:
Tue Jan 27, 2009 6:25 pm |
|
testy1 wrote: | you can do this via css
Code:
a[href$='.pdf'] { padding:0 20px 0 0; background:transparent url(/graphics/icons/pdf.gif) no-repeat center right; }
| |
As an FYI, IE6 (and below) does not support the attribute selector. There are other ways of adding a similar effect through the use of Java Script and the DOM, according to Only registered users can see links on this board! Get registered or login! |
|
|
|
 |
jestrella

|
Posted:
Wed Jan 28, 2009 8:44 pm |
|
Ok, I have been working in some enhancements... Please download this new package and replace old files on your test server with the ones here provided:
http://slaytanic.sourceforge.net/tmp/nukeICONS_dev2.7z [Right click -> Save as]
When everything is in place run iconstest.php from your browser for a quick demo on how the class do all the magic
I am all eyes to read any suggestion you may post.  |
|
|
|
 |
jestrella

|
Posted:
Fri Mar 20, 2009 8:36 pm |
|
So... have somebody give this a try? no new ideas to post? wanna red from you  |
|
|
|
 |
|