Since upgrade 6.5 to 7.6 topics sometimes load real slow

Regular Joined: May 08, 2004 Posts: 77

Since the upgrade from 6.5 to 7.6 the topics sometime load real slow.
Is this a database thing? How to speed up (optimize) things?

Any1?

Subject Matter Expert Joined: Feb 23, 2004 Posts: 358

Impossible to advise what to optimize without knowing what needs optimizing! Wink

You'll need to find some speed scripts and test various things.. it also may be a theme related problem. What comes to mind lastly is that in some viewtopic.php mods, there is a section of code that forcefully resizes remote avatars to the maximums set in Forums ACP. I've seen this little bit of code practically bring some sites to their knees. Of course, these sites were slow to begin with...

Wish I could be of more help, but that's all I have atm until you can find something more specific to analyze.

PHrEEk

Posted: Sat Jan 29, 2005 6:52 am

Forcefully resize remote avatars. That what wasnt in there before.
How can i test this, how to turn off this code ?

(Where can i find some speedscripts?)

Thx!
Himmel

Posted: Sat Jan 29, 2005 7:22 pm

ok, this is a lotta code... so here ya go:

This is in /modules/Forums/viewtopic.php

Code:

      switch( $postrow[$i]['user_avatar_type'] )


      {


         case USER_AVATAR_UPLOAD:


            $poster_avatar = ( $board_config['allow_avatar_upload'] ) ? '<img src="' . $board_config['avatar_path'] . '/' . $postrow[$i]['user_avatar'] . '" alt="" border="0" />' : '';


            break;


         case USER_AVATAR_REMOTE:


                ////////////////////////////////////////////////////////


                // Resize Remote Avatars mod


                // Make sure that both dimensions of remote avatars conform to the limits


                // set in the admin control panel. Use the width and height attributes 


                // on the <img> tag to control the image size in the browser. 


                // Reduce the largest dimension of the remote image to the maximum allowed 


                // in the ACP, then reduce the other dimension to maintain the aspect ratio.


                //


                // phpbb 2.0.6 impl


                // $poster_avatar = ( $board_config['allow_avatar_remote'] ) ? '<img src="' . $postrow[$i]['user_avatar'] . '" alt="" border="0" />' : '';





                // new impl


                list($width, $height) = @getimagesize($postrow[$i]['user_avatar']);


                $width_attr = '';


                $height_attr = '';


                // resize the avatar in the browser if either dimension is too large


                $resize = $width > $board_config['avatar_max_width'] || $height > $board_config['avatar_max_height'];





                // set max dimension and adjust the other according to the ratio


                if ( $resize )


                {


                    if ( $width == $height ) 


                    {


                        $width_attr = ' width="' . $board_config['avatar_max_width'] . '"';


                        $height_attr = ' height="' . $board_config['avatar_max_height'] . '"';


                    }


                    else if ( $width > $height )


                    {


                        $width_attr = ' width="' . $board_config['avatar_max_width'] . '"';


                        $height_attr = ' height="' . $board_config['avatar_max_width'] * $height / $width . '"';


                    }


                    else // $height > $width


                    {


                        $width_attr = ' width="' . $board_config['avatar_max_height'] * $width / $height . '"';


                        $height_attr = ' height="' . $board_config['avatar_max_height'] . '"';


                    }


                }


                $poster_avatar = ( $board_config['allow_avatar_remote'] ) ? '<img src="' . $postrow[$i]['user_avatar'] . '" alt="" border="0"' . $width_attr . $height_attr . '/>' : '';


                // end Resize Remote Avatars mod


                ////////////////////////////////////////////////////////


            break;

To remove it, replace that section of code with

Code:

      switch( $postrow[$i]['user_avatar_type'] )


      {


         case USER_AVATAR_UPLOAD:


            $poster_avatar = ( $board_config['allow_avatar_upload'] ) ? '<img src="' . $board_config['avatar_path'] . '/' . $postrow[$i]['user_avatar'] . '" alt="" border="0" />' : '';


            break;


         case USER_AVATAR_REMOTE:


            break;

If you don't have that exact code, you may have something similar in that section. I don't know how many resize mods are floating around. If your code looks like the replacement code to begin with, then you don't even have this mod and therefore this isn't your speed issue.

If anyone -needs- this mod, just do the reverse and add the top code. It does definitely work.. if your server is fast to begin with. It seems to 'stall' while it examines and formats each avatar in each reply.

Maybe some experts in the area of PHP and graphic manipulation can clean this code up (if possible).

PHrEEk

Posted: Tue Feb 01, 2005 6:25 am

Thx!
Did exactly whats described above. It speeding things up !
But when replacing the exact code the remote avatars are gone...

This is what i have after replacing the code: (small part extra code before and after to show all)

Code:

//


// Okay, let's do the loop, yeah come on baby let's do the loop


// and it goes like this ...


//


for($i = 0; $i < $total_posts; $i++)


{


        $poster_id = $postrow[$i]['user_id'];


        $poster = ( $poster_id == ANONYMOUS ) ? $lang['Guest'] : $postrow[$i]['username'];





        $post_date = create_date($board_config['default_dateformat'], $postrow[$i]['post_time'], $board_config['board_timezone']);





        $poster_posts = ( $postrow[$i]['user_id'] != ANONYMOUS ) ? $lang['Posts'] . ': ' . $postrow[$i]['user_posts'] : '';





        $poster_from = ( $postrow[$i]['user_from'] && $postrow[$i]['user_id'] != ANONYMOUS ) ? $lang['Location'] . ': ' . $postrow[$i]['user_from'] : '';


        $poster_from = ereg_replace(".gif", "", $poster_from);


        $poster_joined = ( $postrow[$i]['user_id'] != ANONYMOUS ) ? $lang['Joined'] . ': ' . $postrow[$i]['user_regdate'] : '';





        $poster_avatar = '';


        if ( $postrow[$i]['user_avatar_type'] && $poster_id != ANONYMOUS && $postrow[$i]['user_allowavatar'] )


        {


                switch( $postrow[$i]['user_avatar_type'] ) 


      { 


         case USER_AVATAR_UPLOAD: 


            $poster_avatar = ( $board_config['allow_avatar_upload'] ) ? '<img src="' . $board_config['avatar_path'] . '/' . $postrow[$i]['user_avatar'] . '" alt="" border="0" />' : ''; 


            break; 


         case USER_AVATAR_REMOTE: 


            break;


                        case USER_AVATAR_GALLERY:


                                $poster_avatar = ( $board_config['allow_avatar_local'] ) ? '<img src="' . $board_config['avatar_gallery_path'] . '/' . $postrow[$i]['user_avatar'] . '" alt="" border="0" />' : '';


                                break;


                }


        }





        //


        // Default Avatar MOD - Begin


        //

Where did i go wrong?

Posted: Tue Feb 01, 2005 10:18 pm

Sorry, my bad! Forgot to put the default code back in... here's that line:

Code:

         case USER_AVATAR_REMOTE:


            $poster_avatar = ( $board_config['allow_avatar_remote'] ) ? '<img src="' . $postrow[$i]['user_avatar'] . '" alt="" border="0" />' : '';


            break;

Hope that's it for ya! = )

PHrEEk

Posted: Wed Feb 02, 2005 6:20 am

Thx Super PHrEEkie !

You did it again. Forums are much faster now!

Super!